fix(example): change suggestion for windows compatability #3220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The suggested curl statement should work for all users out-of-the-box. Regression tested against windows, macos, and linux (dev container).
seanmonstar
approved these changes
May 5, 2023
0xE282B0
pushed a commit
to 0xE282B0/hyper
that referenced
this pull request
Jan 12, 2024
…ium#3220) The suggested curl statement should work for all users out-of-the-box. Regression tested against windows, macos, and linux (dev container).
0xE282B0
pushed a commit
to 0xE282B0/hyper
that referenced
this pull request
Jan 16, 2024
…ium#3220) The suggested curl statement should work for all users out-of-the-box. Regression tested against windows, macos, and linux (dev container). Signed-off-by: Sven Pfennig <s.pfennig@reply.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Updated echo example service root path instructions to work for Windows users out-of-the-box.
Inspiration
Tripped over this during some midnight coding 😵💫
Testing
I put this change through a full loop1 of testing on:
No regressions discovered.
Criticism Welcome 😄
If bypassing the reporting step was inappropriate, I will abandon this PR and create an issue accordingly 👍🏻
Footnotes
repeating the process pictured above ↩